Fix handling out of of range exponent in numbers#971
Merged
byroot merged 1 commit intoruby:masterfrom Apr 15, 2026
Merged
Conversation
Fix: ruby#970 If the parsed exponent overflows a `int32_t` passing it to ryu is incorrect. We could pass it to `rb_cstr_to_dbl` but then Ruby will emit an annoying warning, instead we can coerce to `0.0` and `Inf`.
lopopolo
reviewed
Apr 15, 2026
| } | ||
|
|
||
| if (RB_UNLIKELY(exponent > INT32_MAX)) { | ||
| return CInfinity; |
There was a problem hiding this comment.
don't we have to coerce to a signed infinity depending on the negative value?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #970
If the parsed exponent overflows a
int32_tpassing it to ryu is incorrect.We could pass it to
rb_cstr_to_dblbut then Ruby will emit an annoying warning, instead we can coerce to0.0andInf.