Skip to content

feat: add merthyr tydfil county borough council scraper#2092

Open
InertiaUK wants to merge 1 commit into
robbrad:masterfrom
InertiaUK:feat/merthyr-tydfil-council
Open

feat: add merthyr tydfil county borough council scraper#2092
InertiaUK wants to merge 1 commit into
robbrad:masterfrom
InertiaUK:feat/merthyr-tydfil-council

Conversation

@InertiaUK
Copy link
Copy Markdown
Contributor

Summary

  • New scraper for Merthyr Tydfil County Borough Council (population ~60k, South Wales)
  • Simple POST API at merthyr.gov.uk/umbraco/Surface/BinDaySurface/GetCollectionDay
  • Area-based collection by postcode - no UPRN or house number needed
  • Parses day names + week-one/two fortnightly alternation from HTML response
  • Returns weekly recycling + fortnightly household waste and garden waste dates
  • Pure HTTP with requests + BeautifulSoup - no Selenium needed

Notes

  • Council is actively changing collection rounds; some CF47 postcodes return no data
  • CF48 area has best coverage currently

Test plan

  • Tested with CF48 3BN (Dowlais) - returns 8 bins across 3 types
  • Also tested CF47 0HE, CF48 2BU
  • End-to-end verified through Kepthouse API

Simple POST API at merthyr.gov.uk - area-based collection by postcode.
Parses day names and week-one/two fortnightly alternation from HTML
response. Returns weekly recycling + fortnightly household/garden waste.
Pure HTTP - no Selenium needed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

Warning

Rate limit exceeded

@InertiaUK has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 14 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3d4e6514-ad79-4fb3-8374-e2b658898ab5

📥 Commits

Reviewing files that changed from the base of the PR and between 8ecf878 and e5c2958.

📒 Files selected for processing (2)
  • uk_bin_collection/tests/input.json
  • uk_bin_collection/uk_bin_collection/councils/MerthyrTydfilCountyBoroughCouncil.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.67%. Comparing base (8ecf878) to head (e5c2958).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2092   +/-   ##
=======================================
  Coverage   86.67%   86.67%           
=======================================
  Files           9        9           
  Lines        1141     1141           
=======================================
  Hits          989      989           
  Misses        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant