Fix accidentally inverted logic in listener log check#1231
Merged
Conversation
Follows up #1216 with a fix whereby the conditional on the check on whether to log an error was accidentally inverted.
acc51ff to
4918ca2
Compare
bgentry
approved these changes
Apr 26, 2026
Contributor
bgentry
left a comment
There was a problem hiding this comment.
Whoops, sorry for not catching in review
Contributor
Author
|
Nope, no worries. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up #1216 with a fix whereby the conditional on the check on
whether to log an error was accidentally inverted.