fix: Partition Modal to use BasicTable component#9257
Conversation
Replaces the custom tanstack-table + virtualizer in `PartitionsTable` with the shared `BasicTable` component, and updates the dialog hosts (`ModelPartitionsDialog`, `PartitionsBrowser`) used by Rill Developer and Rill Cloud. - Adds a search input that filters across partition key, data, and error. - Adds clickable-header sorting on Executed on (default desc), Elapsed time, and Watermark. - Fixes the dialog overlay: the table fills the dialog body via flex sizing instead of a fixed 600px height. - Auto-fetches all pages on open so search and sort cover the full set. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Enable header sorting on the `Data` column using each partition's `data.uri` value. - Widen the actions column (`minmax(180px, auto)`) so the `Refresh partition` button is no longer clipped at the right border. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Fall back to `partition.key` when a partition has no `data.uri` (SQL- based partitions), so Data-column sort is deterministic for all partition types. - Rewrite `PartitionsFilter` as a `DropdownMenu` with the same trigger styling (border, bg-input, caret) as the resources filters. - Use the resources toolbar pattern in both partition dialogs: `large` `Search` input on the left in a `flex-1 min-w-0 min-h-9` wrapper, with the filter dropdown to the right. - Give the dialog a fixed `h-[80vh]` instead of `max-h-[90vh]` so the overall modal no longer resizes while typing in the search box. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Swap `DropdownMenu.RadioItem` (filled-circle indicator) for `DropdownMenu.CheckboxItem` (check indicator) to match the resources filter visual pattern. Single-select semantics are preserved by ignoring uncheck events — clicking an option sets it, clicking the already-selected option is a no-op. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Watermark still renders with millisecond precision; `Executed on` now shows seconds only. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
BasicTable with search and sort|
⏺ Code review results Agents run: svelte-frontend-reviewer (✓), design-reviewer (failed — model access error), validators (failed — same). I Findings after manual validation All critical/warning findings from the reviewer were false positives. Keeping only what's actionable: #: 1 ──────────────────────────────────────── Net: no blocking issues found. Ship it. |
Migrates the model partitions table (used in Rill Developer and Rill Cloud) from a custom tanstack-table + virtualizer to the shared
BasicTablecomponent, and tightens the dialog overlay layout.flex-1 min-h-0 overflow-autoinstead of a fixed 600px height.https://www.loom.com/share/9d1ba05bf66e4336a1b290486e80cd49
Checklist:
Developed in collaboration with Claude Code