Skip to content

[PLAT-440] roll up routing in metrics view#9180

Merged
pjain1 merged 34 commits intomainfrom
rollup_mv
Apr 21, 2026
Merged

[PLAT-440] roll up routing in metrics view#9180
pjain1 merged 34 commits intomainfrom
rollup_mv

Conversation

@pjain1
Copy link
Copy Markdown
Member

@pjain1 pjain1 commented Apr 3, 2026

  • Add rollup table config to metrics view proto and YAML parser
  • Implement query routing: eligible rollups are selected based on grain derivability, dimension/measure coverage, timezone match, time range alignment, and time coverage
  • Prefer coarsest grain among eligible rollups; break ties by smallest data range
  • For no-time-range queries ("all data"), verify the rollup covers the base table's full range rather than skipping coverage checks

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@pjain1 pjain1 closed this Apr 3, 2026
@pjain1 pjain1 reopened this Apr 3, 2026
@pjain1 pjain1 changed the title roll up routing in metrics view [PLAT-440] roll up routing in metrics view Apr 5, 2026
@pjain1 pjain1 requested a review from begelundmuller April 6, 2026 05:32
Comment thread runtime/metricsview/executor/watermark_cache.go Outdated
Comment thread proto/rill/runtime/v1/resources.proto Outdated
Comment thread proto/rill/runtime/v1/resources.proto Outdated
Comment thread proto/rill/runtime/v1/time_grain.proto Outdated
Comment thread runtime/parser/parse_metrics_view.go Outdated
Comment thread runtime/parser/parse_metrics_view.go Outdated
Comment thread runtime/metricsview/executor/executor_validate.go Outdated
Comment thread runtime/metricsview/executor/executor_validate.go Outdated
Comment thread runtime/metricsview/executor/executor_validate.go Outdated
Comment thread runtime/metricsview/executor/watermark_cache.go Outdated
Comment thread runtime/metricsview/executor/watermark_cache.go Outdated
@pjain1 pjain1 requested a review from begelundmuller April 13, 2026 16:00
Comment thread proto/rill/runtime/v1/resources.proto Outdated
Comment thread runtime/metricsview/executor/executor.go Outdated
Comment thread runtime/metricsview/executor/executor_rewrite_rollup.go
Comment thread runtime/metricsview/executor/executor_rewrite_rollup.go
Comment thread runtime/metricsview/executor/executor_rewrite_rollup.go
Comment thread runtime/metricsview/executor/executor_rewrite_rollup.go
Comment thread runtime/metricsview/executor/executor_rewrite_rollup.go Outdated
Comment thread runtime/resolvers/metricsview_timestamps.go Outdated
@pjain1 pjain1 requested a review from begelundmuller April 16, 2026 11:10
Comment thread runtime/metricsview/executor/export_test.go Outdated
Comment thread runtime/metricsview/rollup.go Outdated
Comment thread runtime/metricsview/executor/executor_validate.go Outdated
Comment thread runtime/metricsview/executor/executor_validate.go Outdated
Comment thread runtime/queries/metricsview_aggregation.go Outdated
Comment thread runtime/resolvers/metricsview_time_range.go
@pjain1 pjain1 requested a review from begelundmuller April 21, 2026 05:35
Comment thread runtime/metricsview/executor/executor_rollup_integration_test.go Outdated
@pjain1 pjain1 merged commit 1ac8868 into main Apr 21, 2026
19 of 21 checks passed
@pjain1 pjain1 deleted the rollup_mv branch April 21, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants