fix(lint): strip k8s version suffix from EC version in DiscoverECVersion#704
Merged
fix(lint): strip k8s version suffix from EC version in DiscoverECVersion#704
Conversation
EC versions include a +k8s-<major>.<minor> suffix (e.g. "3.0.0-beta.2+k8s-1.34") that should be stripped before use, matching the behavior in the EC project. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
emosbaugh
changed the title
sgalsaleh
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+k8s-<major>.<minor>suffix (e.g.3.0.0-beta.2+k8s-1.34) that needs to be stripped before useparseECVersionFromFilenow applies the same regex the EC project uses:\+k8s-(\d+\.\d+)$Test plan
go test ./pkg/lint2/ -run TestParseECVersionFromFilego test ./pkg/lint2/ -run TestDiscoverECVersion🤖 Generated with Claude Code