Fix latest checkpoint pointers for custom prefixes#188
Open
limjoobin wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #187.
Summary
Latest-pointer keys were always written as
checkpoint_latest:{thread_id}:{checkpoint_ns}, ignoring configuredcheckpoint_prefixvalues. Since the checkpoint document keys honourcheckpoint_prefix, two deployments with different checkpoint prefixes could overwrite each other's latest pointer when using the same thread ID and namespace.This PR fixes latest checkpoint pointer keys so custom
checkpoint_prefixvalues fully isolate saver instances sharing the same Redis Stack.Fixes
This PR changes latest-pointer keys to use
{checkpoint_prefix}_latest:{thread_id}:{checkpoint_ns}. The default prefix still producescheckpoint_latest:*, preserving compatibility for existing default deployments.Tests
checkpoint_id.