tdo_panel: bcm2712-gpu: Add dsi panel driver; by flash-fea · Pull Request #7316 · raspberrypi/linux

flash-fea · 2026-04-15T02:14:23Z

- Add vc4-kms-dsi-panel-overlay.dts for tdo panel compatiable all in use.
- Simplify add panel-tdo-dsi-v1.c as module to driver tdo panel.
- __overrides__ parameter can be add in config.txt for customers.

- Add vc4-kms-dsi-panel-overlay.dts for tdo panel compatiable. - Simplify add panel-tdo-dsi-v1.c as module to driver tdo panel. - __overrides__ parameter can be add in config.txt for customers. Signed-off-by: kun_liu <kun_liu@shtdo.com>

pelwell · 2026-04-15T09:41:43Z

I should tell you that this PR will never get merged as it stands because it targets rpi-6.12.y, which is now frozen except for bug fixes. rpi-6.18.y will be the source of the next released kernel, and PRs adding new features should be submitted against it.

pelwell · 2026-04-15T09:45:15Z

You'll need to rebase/cherry-pick your changes onto a local 6.18 branch, then force push it to GitHub and change the base branch by editing the PR (click the pencil icon labelled "Edit title").

flash-fea · 2026-04-15T10:11:36Z

OK,thanks,rpi-6.18.y can use module 4B?

pelwell · 2026-04-15T10:23:38Z

Here are some other things that I think will need to be changed before we consider merging this:

Please also add CONFIG_DRM_PANEL_TDO_DSI_V1=m to the other 4 defconfig files - arch/arm/configs/bcmrpi_defconfig, arch/arm/configs/bcm2709_defconfig, arch/arm64/configs/bcm2711_rt_defconfig and arch/arm64/configs/bcm2712_defconfig.
Please split the code into 3 commits:

one for the .c code, Kconfig and module Makefile changes,
one for the overlay, README and dts Makefile changes, and
one for the _defconfig changes.

rpi-6.18.y can use module 4B?

I don't understand your question - please ask it another way.

6by9

Sorry I had this under review before you'd moved it to 6.18.

Seeing as your email address is at shtdo.com, are you actually representing TDO as the manufacturer, and is this a product that you are launching for the Pi?

Ideally the driver should be upstreamed to the mainline Linux kernel via the dri-devel mailing list, but for products specifically targeting the Pi (such as Waveshare's panels) we have accepted panel drivers here (eg panel-waveshare-dsi and panel-waveshare-dsi-v2).

The V1 Waveshare panels have generally used chips such as ChipOne ICN6211 DSI to parallel bridges with a microcontroller on the board to configure it. That means the driver is very simple but also bespoke to them rather than the panel manufacturer.
Their V2 panels are native DSI, and hence have configuration sequences. It would be nice to identify the actual panel in those cases, but it's not worth us making the fuss. If upstreamed then the questions would be asked again.

6by9 · 2026-04-15T16:07:18Z

+Info:   Enable the Tdo DSI screen,keep adding.
+        Requires vc4-kms-v3d to be loaded.
+Load:   dtoverlay=vc4-kms-dsi-tdo-panel,<param>=<val>
+Params: tl034wvs03              4.0" 480x480 2lane


4.0"?
https://www.panelook.com/TL034WVS03-B1476A-TDO-3-4-inch-With-CTP-480-480-250nits-40pins-SPI-3line18bitRGB-interface-detail_133606.html says it's 3.4"

6by9 · 2026-04-15T16:08:25Z

@@ -0,0 +1,69 @@
+/*
+ * Device Tree overlay for Waveshare DSI Touchscreens


I'm confused as to whether this is a Waveshare product using the TDO display, or TDO submitting this.

6by9 · 2026-04-15T16:09:56Z

+				compatible = "tdo,4.0-dsi-tl040wvs17";
+				status = "okay";
+				reg = <0>;
+				reset-gpios = <&gpio 47 1>;   // Dummy GPIO , Unused or change


The driver uses devm_gpiod_get_optional, so there's no need for a reset-gpio at all.

6by9 · 2026-04-15T16:13:49Z

 	  TDO Y17P controller.

+config DRM_PANEL_TDO_DSI_V1
+        tristate "TDO touchscreen panels V1"


What does a V1 display mean in this terminology? Is there a better family name for these panels?

6by9 · 2026-04-15T16:14:02Z

@@ -0,0 +1,491 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2024 Waveshare International Limited


Waveshare again.

6by9 · 2026-04-15T16:45:28Z

+	struct drm_display_mode *mode;
+
+	mode = drm_mode_duplicate(connector->dev, ctx->desc->mode);
+	dev_err(&ctx->dsi->dev, "%ux,%ux,%ux\n", ctx->desc->mode->hdisplay,


Debugging line left in.

6by9 · 2026-04-15T16:45:54Z

+	struct tdo_panel *ctx;
+	int ret;
+
+	dev_err(&dsi->dev, "dsi panel: %s\n",


Debug line.

6by9 · 2026-04-15T16:46:28Z

+	struct tdo_panel *ctx = mipi_dsi_get_drvdata(dsi);
+
+	if (ctx->reset) {
+		dev_info(&dsi->dev, "shutdown\n");


6by9 · 2026-04-15T16:48:25Z

+	.mode_flags = MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO |
+	MIPI_DSI_MODE_LPM | MIPI_DSI_CLOCK_NON_CONTINUOUS,
+	.lanes = 2,
+	.format = MIPI_DSI_FMT_RGB888,


Realistically do you make any displays in this range that only support something other than RGB888? If not then hardcode dsi->format = MIPI_DSI_FMT_RGB888 at line 412, and remove this from the desc structure.

6by9 · 2026-04-15T16:49:58Z

+static const struct of_device_id tdo_panel_of_match[] = {
+	{ .compatible = "tdo,4.0-dsi-tl034wvs03", &tdo_panel_tl034wvs03_desc },
+	{ .compatible = "tdo,4.0-dsi-tl040wvs17", &tdo_panel_tl040wvs17_desc },
+	{ .compatible = "tdo,4.0-dsi-tl040hds31", &tdo_panel_tl040hds31_desc },


All of these compatible strings should be documented in a dtbinding file. I would have expected just tdo,tl034wvs03 etc, as the part number infers that it is a DSI screen and the size.

(Again is tl034wvs03 actually 4.0" in size?)

flash-fea force-pushed the rpi-6.12.y branch 2 times, most recently from ccab473 to 8cb9447 Compare April 15, 2026 09:15

tdo_panel: bcm2712-gpu: Add dsi panel driver;

89afec1

- Add vc4-kms-dsi-panel-overlay.dts for tdo panel compatiable. - Simplify add panel-tdo-dsi-v1.c as module to driver tdo panel. - __overrides__ parameter can be add in config.txt for customers. Signed-off-by: kun_liu <kun_liu@shtdo.com>

flash-fea force-pushed the rpi-6.12.y branch from 8cb9447 to 89afec1 Compare April 15, 2026 09:17

pelwell changed the base branch from rpi-6.12.y to rpi-6.18.y April 15, 2026 09:42

pelwell changed the base branch from rpi-6.18.y to rpi-6.12.y April 15, 2026 09:43

flash-fea closed this Apr 16, 2026

6by9 reviewed Apr 16, 2026

View reviewed changes

		@@ -0,0 +1,69 @@
		/*
		* Device Tree overlay for Waveshare DSI Touchscreens

Conversation

flash-fea commented Apr 15, 2026

Uh oh!

pelwell commented Apr 15, 2026

Uh oh!

pelwell commented Apr 15, 2026

Uh oh!

flash-fea commented Apr 15, 2026

Uh oh!

pelwell commented Apr 15, 2026

Uh oh!

6by9 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants