arm64: dts: rockchip: Add radxa-cm3j-rpi-cm4-io#539
Open
LZhaoM wants to merge 4 commits intoradxa:linux-6.1-stan-rkr4.1from
Open
arm64: dts: rockchip: Add radxa-cm3j-rpi-cm4-io#539LZhaoM wants to merge 4 commits intoradxa:linux-6.1-stan-rkr4.1from
LZhaoM wants to merge 4 commits intoradxa:linux-6.1-stan-rkr4.1from
Conversation
LZhaoM
commented
Apr 20, 2026
LZhaoM
commented
RadxaYuntian
requested changes
Apr 20, 2026
Files rk3568-radxa-cm3j-rpi-cm4-io.dts and rk3568-radxa-cm3j.dtsi are copied from [0][1][2]. [0]: https://github.com/radxa/kernel/tree/linux-5.10-gen-rkr4.1 [1]: https://github.com/radxa/kernel/blob/00eb929841fd2231793b888c167594d14ae7b274/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3j-rpi-cm4-io.dts [2]: https://github.com/radxa/kernel/blob/00eb929841fd2231793b888c167594d14ae7b274/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3j.dtsi
The node wifi@1 is the child of sdmmc2, and its reg is <1>, which means there is 1 address cell and 0 size cell[0]. Without the definition of address-cells and size-cells, dtc will give the following warnings: ``` rk3568-radxa-cm3j.dtsi:576.3-13: Warning (reg_format): /mmc@fe000000/wifi@1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) rk3568-radxa-cm3j-rpi-cm4-io.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' rk3568-radxa-cm3j-rpi-cm4-io.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' rk3568-radxa-cm3j-rpi-cm4-io.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' rk3568-radxa-cm3j-rpi-cm4-io.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' rk3568-radxa-cm3j.dtsi:574.16-582.4: Warning (avoid_default_addr_size): /mmc@fe000000/wifi@1: Relying on default #address-cells value rk3568-radxa-cm3j.dtsi:574.16-582.4: Warning (avoid_default_addr_size): /mmc@fe000000/wifi@1: Relying on default #size-cells value ``` [0]: See Deivcetree Specification '2.3.5 #address-cells and #size-cells' and '2.3.6 reg'
Define the LEDs. The heartbeat LED on CM4 IO board is set to off because CM3J already has a heartbeat LED, it's not very useful to enable two heartbeat LEDs at the same time.
LZhaoM
force-pushed
the
add-cm3j-rpi-cm4-io-dts
branch
from
6f979e4 to
814641a
Compare
RadxaYuntian
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.