Skip to content

Fail fast when npm is missing during configure #14421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cderv merged 2 commits into from
Apr 24, 2026
+10 −1
Merged

Fail fast when npm is missing during configure #14421

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f946297
Warn and skip preview build when npm is missing during configure
cderv Apr 23, 2026
52f6a76
Error out instead of skipping when npm is missing
cderv Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion package/src/common/configure.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,22 @@ import {
configureDependency,
kDependencies,
} from "./dependencies/dependencies.ts";
import { suggestUserBinPaths } from "../../../src/core/path.ts";
import { suggestUserBinPaths, which } from "../../../src/core/path.ts";
import { buildQuartoPreviewJs } from "./previewjs.ts";
import { isWindows } from "../../../src/deno_ral/platform.ts";

export async function configure(
config: Configuration,
) {
// npm is required later for building quarto-preview.js (used by `quarto
// preview` live-reload). Check upfront to fail fast before downloading
// hundreds of MB of dependencies when npm is missing.
if ((await which("npm")) === undefined) {
throw new Error(
"npm not found on PATH. Please install Node.js (which provides npm) before running configure.",
);
}

// Download dependencies
for (const dependency of kDependencies) {
const targetDir = join(
Expand Down
Loading