Skip to content

WORKAROUND: usb: host: xhci-pci-renesas: enable D3cold PME support#475

Open
akakum-qualcomm wants to merge 1 commit intoqualcomm-linux:qcom-6.18.yfrom
akakum-qualcomm:pcie-d3cold
Open

WORKAROUND: usb: host: xhci-pci-renesas: enable D3cold PME support#475
akakum-qualcomm wants to merge 1 commit intoqualcomm-linux:qcom-6.18.yfrom
akakum-qualcomm:pcie-d3cold

Conversation

@akakum-qualcomm
Copy link
Copy Markdown

@akakum-qualcomm akakum-qualcomm commented Apr 16, 2026

Set the PCI device PME support bit for D3cold in
xhci_pci_renesas_probe().

Without advertising D3cold PME capability, the PCI PM core may avoid putting the Renesas xHCI controller into D3cold, preventing the PCIe device from reaching the deepest low-power state during suspend/runtime PM.

Update dev->pme_support to include PCI_D3cold so the device is allowed to enter D3cold when appropriate.

Signed-off-by: Akash Kumar akash.kumar@oss.qualcomm.com

CRs-Fixed: 4495614

Set the PCI device PME support bit for D3cold in
xhci_pci_renesas_probe().

Without advertising D3cold PME capability, the PCI PM core may avoid
putting the Renesas xHCI controller into D3cold, preventing the PCIe
device from reaching the deepest low-power state during suspend/runtime
PM.

Update dev->pme_support to include PCI_D3cold so the device is allowed
to enter D3cold when appropriate.

Signed-off-by: Akash Kumar <akash.kumar@oss.qualcomm.com>
@akakum-qualcomm
Copy link
Copy Markdown
Author

We are discussing with renesas to review and upstream this change, mean while to unblock power team pushed as a workaround fo now.

@qcomlnxci
Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 sm8750-mtp x1e80100-crd
BT_FW_KMD_Service ◻️ ⚠️ skip ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
BT_ON_OFF ◻️ ❌ Fail ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
BT_SCAN ◻️ ❌ Fail ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
CPUFreq_Validation ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
CPU_affinity ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
DSP_AudioPD ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
Ethernet ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ⚠️ skip ◻️ ◻️
Freq_Scaling ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
GIC ◻️ ❌ Fail ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
IPA ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
Interrupts ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
OpenCV ◻️ ⚠️ skip ◻️ ◻️ ⚠️ skip ⚠️ skip ◻️ ◻️
PCIe ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
Probe_Failure_Check ◻️ ❌ Fail ◻️ ◻️ ✅ Pass ❌ Fail ◻️ ◻️
RMNET ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
UFS_Validation ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
USBHost ◻️ ❌ Fail ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
WiFi_Firmware_Driver ◻️ ⚠️ skip ◻️ ◻️ ⚠️ skip ⚠️ skip ◻️ ◻️
WiFi_OnOff ◻️ ⚠️ skip ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
cdsp_remoteproc ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
hotplug ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
irq ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
kaslr ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
pinctrl ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
qcom_hwrng ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
remoteproc ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
rngtest ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
shmbridge ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ❌ Fail ◻️ ◻️
smmu ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
watchdog ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️
wpss_remoteproc ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ◻️ ◻️

@shashim-quic
Copy link
Copy Markdown

We are discussing with renesas to review and upstream this change, mean while to unblock power team pushed as a workaround fo now.

why don't you submit the change upstream ?

@akakum-qualcomm
Copy link
Copy Markdown
Author

We are discussing with renesas to review and upstream this change, mean while to unblock power team pushed as a workaround fo now.

why don't you submit the change upstream ?

We will if renesas approves this, we want to approach vendor first and check with them if any fix present in firmware itself, which can help fix this issue so we can use updated firmware directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants