version to 7.15.2#449
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the package version to 7.15.2, adds a local settings file to the git ignore list, and updates the changelog. However, the reviewer noted that while the changelog mentions a fix for the pfop pipeline parameter, the actual code implementation for this fix is missing from the PR. Additionally, a formatting improvement was suggested for the changelog header to include a blank line.
| @@ -1,4 +1,6 @@ | |||
| ## CHANGE LOG | |||
| ## 7.15.2 | |||
| - 对象存储,修复 pfop pipeline 参数无效问题 | |||
There was a problem hiding this comment.
The changelog entry mentions a fix for the pfop pipeline parameter, but the actual code changes are missing from this PR. The current implementation of pfop in qiniu/fop.js does not correctly handle optional arguments (e.g., when pipeline is omitted and options is passed as the 4th argument), which leads to the pipeline parameter being set to an object and the callback being lost. Please include the fix in this pull request.
| @@ -1,4 +1,6 @@ | |||
| ## CHANGE LOG | |||
| ## 7.15.2 | |||
| @@ -1,4 +1,6 @@ | |||
| ## CHANGE LOG | |||
| ## 7.15.2 | |||
There was a problem hiding this comment.
There is no blank line between the top-level ## CHANGE LOG heading and the new ## 7.15.2 section. Every prior version entry is separated by a blank line, so this breaks the established formatting convention.
| ## 7.15.2 | |
| ## 7.15.2 |
| .idea | ||
| yarn.lock | ||
|
|
||
| .claude/settings.local.json |
There was a problem hiding this comment.
This ignores only settings.local.json inside .claude/. Claude Code tooling may generate other files in that directory (e.g. settings.json, memory files, task lists). Consider broadening the pattern to avoid accidentally committing those in the future:
| .claude/settings.local.json | |
| .claude/ |
If there are files under .claude/ that should be tracked (e.g. project-level CLAUDE.md or shared settings), you can unignore them explicitly with !.claude/CLAUDE.md.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #449 +/- ##
===========================================
- Coverage 86.14% 23.45% -62.70%
===========================================
Files 27 33 +6
Lines 2173 2294 +121
Branches 474 0 -474
===========================================
- Hits 1872 538 -1334
- Misses 301 1756 +1455 🚀 New features to boost your workflow:
|
No description provided.