Skip to content

version to 7.15.2#449

Merged
YangSen-qn merged 2 commits into
qiniu:masterfrom
YangSen-qn:master
Apr 22, 2026
Merged

version to 7.15.2#449
YangSen-qn merged 2 commits into
qiniu:masterfrom
YangSen-qn:master

Conversation

@YangSen-qn
Copy link
Copy Markdown
Contributor

No description provided.

@qiniu-prow qiniu-prow Bot added the size/XS label Apr 22, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package version to 7.15.2, adds a local settings file to the git ignore list, and updates the changelog. However, the reviewer noted that while the changelog mentions a fix for the pfop pipeline parameter, the actual code implementation for this fix is missing from the PR. Additionally, a formatting improvement was suggested for the changelog header to include a blank line.

Comment thread CHANGELOG.md
@@ -1,4 +1,6 @@
## CHANGE LOG
## 7.15.2
- 对象存储,修复 pfop pipeline 参数无效问题
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The changelog entry mentions a fix for the pfop pipeline parameter, but the actual code changes are missing from this PR. The current implementation of pfop in qiniu/fop.js does not correctly handle optional arguments (e.g., when pipeline is omitted and options is passed as the 4th argument), which leads to the pipeline parameter being set to an object and the callback being lost. Please include the fix in this pull request.

Comment thread CHANGELOG.md
@@ -1,4 +1,6 @@
## CHANGE LOG
## 7.15.2
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Please add a blank line between the ## CHANGE LOG header and the new version entry ## 7.15.2 to maintain consistent formatting and improve readability.

Suggested change
## 7.15.2
## 7.15.2

Copy link
Copy Markdown

@fennoai fennoai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clean version-bump PR. Two minor nits below.

Comment thread CHANGELOG.md
@@ -1,4 +1,6 @@
## CHANGE LOG
## 7.15.2
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no blank line between the top-level ## CHANGE LOG heading and the new ## 7.15.2 section. Every prior version entry is separated by a blank line, so this breaks the established formatting convention.

Suggested change
## 7.15.2
## 7.15.2

Comment thread .gitignore
.idea
yarn.lock

.claude/settings.local.json
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ignores only settings.local.json inside .claude/. Claude Code tooling may generate other files in that directory (e.g. settings.json, memory files, task lists). Consider broadening the pattern to avoid accidentally committing those in the future:

Suggested change
.claude/settings.local.json
.claude/

If there are files under .claude/ that should be tracked (e.g. project-level CLAUDE.md or shared settings), you can unignore them explicitly with !.claude/CLAUDE.md.

@qiniu-prow qiniu-prow Bot added size/S and removed size/XS labels Apr 22, 2026
@YangSen-qn YangSen-qn merged commit 64e40a4 into qiniu:master Apr 22, 2026
8 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 23.45%. Comparing base (5188200) to head (334642b).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #449       +/-   ##
===========================================
- Coverage   86.14%   23.45%   -62.70%     
===========================================
  Files          27       33        +6     
  Lines        2173     2294      +121     
  Branches      474        0      -474     
===========================================
- Hits         1872      538     -1334     
- Misses        301     1756     +1455     

see 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant