Use Conference.hostname in .ics export instead of hardcoded host#4663
Conversation
The favourites-calendar .ics export hardcoded https://2026.pycon.it for the event description Info line and the URL property. Build the URL from the per-conference hostname field (added in #4662) so the link is correct for any conference. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR replaces two hardcoded Issues1. Silent malformed URL when
2.
3. The rest of the codebase uses 4. Pinned hostname weakens the regression test (Low)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4663 +/- ##
=======================================
Coverage 92.52% 92.52%
=======================================
Files 359 359
Lines 10799 10800 +1
Branches 821 821
=======================================
+ Hits 9992 9993 +1
Misses 696 696
Partials 111 111 🚀 New features to boost your workflow:
|
Summary
The favourites-calendar
.icsexport hardcodedhttps://2026.pycon.itin two places — the event descriptionInfo:line and theURLproperty. This builds the URL from the per-conferencehostnamefield (added in #4662) so the link is correct for any conference.Changes
backend/schedule/views.py— buildevent_urlonce fromconference.hostname, reuse for the description and theurlproperty.backend/schedule/tests/test_views.py— pinConferenceFactory(hostname="2026.pycon.it")and assert both URLs viaconference.hostname(factory default hostname isconference{n}.example.com), so the test would fail if the host were re-hardcoded.Verification
schedule/tests/test_views.py— 4 passedruff checkclean2026.pycon.itliteral left inviews.py🤖 Generated with Claude Code