gh-148370: prevent quadratic behavior in configparser.ParsingError.combine#148452
Merged
picnixz merged 3 commits intopython:mainfrom Apr 13, 2026
Merged
Conversation
picnixz
added
needs backport to 3.13
serhiy-storchaka
approved these changes
Apr 13, 2026
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. 👍
The whole design is questionable (why do we need to raise multiple exception?), but we should work with what we have.
picnixz
commented
Apr 13, 2026
serhiy-storchaka
approved these changes
Apr 13, 2026
Member
Author
|
I'm merge main into this branch because iOS tests failed twice. |
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 13, 2026
…rror.combine` (pythonGH-148452) (cherry picked from commit 2662db0c45aa16232136628457a53681b6683c25) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-148532 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 13, 2026
…rror.combine` (pythonGH-148452) (cherry picked from commit 2662db0) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-148533 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jaraco Just to be sure, but the interface of parser exceptions is private, i.e. only the exception names and some documented fields are considered part of the public API, right?
ParsingError.combine()when many lines fail to parse #148370