Defer WebGPU buffer destruction until submit#8652
Merged
mvaligursky merged 1 commit intoplaycanvas:mainfrom Apr 27, 2026
Merged
Defer WebGPU buffer destruction until submit#8652mvaligursky merged 1 commit intoplaycanvas:mainfrom
mvaligursky merged 1 commit intoplaycanvas:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Defers destruction of underlying WebGPU buffers so they aren’t destroyed while still referenced by already-recorded command buffers (e.g., via bind groups), matching the existing deferred-destroy pattern used for WebGPU textures.
Changes:
- Route
WebgpuBuffer.destroy()throughdevice.deferDestroy(...)instead of callingGPUBuffer.destroy()immediately. - Add clarifying inline comments explaining why destruction must be deferred.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
willeastcott
approved these changes
Apr 25, 2026
mvaligursky
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GPUBuffer.destroy()inWebgpuBuffer.destroy()until pending command buffers have been submitted.Details
A
GPUBuffercan still be referenced by recorded command buffers through bind groups even after the engine-side buffer wrapper is destroyed. Destroying the underlying WebGPU buffer immediately can invalidate a laterqueue.submit()with validation errors such as “buffer used in submit while destroyed”.This change routes buffer destruction through
device.deferDestroy(...), so the underlyingGPUBufferis destroyed only after pending command buffers are submitted.Test Plan