Skip to content

[diffs] Improve onPostRender API#746

Merged
amadeus merged 5 commits into
mainfrom
amadeus/on-render-fix
May 28, 2026
Merged

[diffs] Improve onPostRender API#746
amadeus merged 5 commits into
mainfrom
amadeus/on-render-fix

Conversation

@amadeus
Copy link
Copy Markdown
Member

@amadeus amadeus commented May 27, 2026

Some improvements to the onPostRender API. onPostRender now receives a new prop called phase. The possible values for this phase are: 'mount', 'update', and 'unmount'. This can allow a lot more power around orchestrating third party DOM updates if necessary.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pierre-docs-diffshub Ready Ready Preview May 28, 2026 12:07am
pierre-docs-trees Ready Ready Preview May 28, 2026 12:07am
pierrejs-diff-demo Ready Ready Preview May 28, 2026 12:07am
pierrejs-docs Ready Ready Preview May 28, 2026 12:07am

Request Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 88068c8463

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/diffs/src/components/File.ts Outdated
Comment thread packages/diffs/src/components/FileDiff.ts Outdated
@amadeus
Copy link
Copy Markdown
Member Author

amadeus commented May 27, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 78bc6458ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/diffs/src/components/File.ts
Comment thread packages/diffs/src/components/FileDiff.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant