Skip to content

fix: Make milestone id assignment bulletproof #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greatestview wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

fix: Make milestone id assignment bulletproof #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,8 +321,9 @@ async function transferMilestones(usePlaceholders: boolean) {
let milestones: (GitLabMilestone | MilestoneImport)[] =
await gitlabApi.ProjectMilestones.all(settings.gitlab.projectId);

// sort milestones in ascending order of when they were created (by id)
milestones = milestones.sort((a, b) => a.id - b.id);
// sort milestones in ascending order of their project-scoped id (iid),
// since the placeholder logic relies on iid ordering
milestones = milestones.sort((a, b) => a.iid - b.iid);

// get a list of the current milestones in the new GitHub repo (likely to be empty)
const githubMilestones = await githubHelper.getAllGithubMilestones();
Expand Down