Support psalm's class-string-map<T of Foo, T> utility type#306
Open
lacatoire wants to merge 3 commits intophpDocumentor:2.xfrom
Open
Support psalm's class-string-map<T of Foo, T> utility type#306lacatoire wants to merge 3 commits intophpDocumentor:2.xfrom
lacatoire wants to merge 3 commits intophpDocumentor:2.xfrom
Conversation
Rewrites `class-string-map<T of Foo, T>` into `array<class-string<Foo>, <value-with-T-substituted>>` before passing the input to the phpstan parser (which otherwise chokes on the `T of Foo` template binding syntax). Nested occurrences are expanded from the innermost outwards. Fixes phpDocumentor#266
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites
class-string-map<T of Foo, T>into the equivalentarray<class-string<Foo>, <value-with-T-substituted>>before passing the input to the underlying phpstan parser (which otherwise chokes on theT of Footemplate binding syntax). Nested occurrences are expanded from the innermost outwards; union/nullable value expressions are preserved.Fixes #266