Open
Conversation
The PIDFile directive is unnecessary for services using Type=notify (if systemd integration is enabled) or Type=simple and is discouraged by the systemd.service(5) manual. Since systemd monitors the main PID directly from the process executed in ExecStart, it does not need a PID file to track the service. Furthermore, the default configuration of php-fpm.conf has 'pid' commented out, which is equivalent to not having a PID file. Closes php#21740
Currently, php-fpm.service relies on the default KillMode=control-group, which sends SIGTERM to all processes in the cgroup simultaneously. This can interfere with php-fpm's internal process management, where the master process is designed to handle the graceful termination of its child workers. Setting KillMode=mixed ensures that SIGTERM is sent only to the master process, allowing it to orchestrate a clean shutdown. If the master process fails to exit within TimeoutStopSec, systemd will send SIGKILL to all processes in the cgroup. Additionally, if the master exits but leaves orphaned children, systemd will clean them up via SIGKILL. This mode has been supported since systemd 209 and provides a more robust shutdown sequence for master-worker architectures. Closes php#18655
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See each commit. Thanks.