Fix: Resolve curl_close deprecation warning on php 8.5#100
Merged
Conversation
> Deprecated: Function curl_close() is deprecated since 8.5, > as it has no effect since PHP 8.0
There was a problem hiding this comment.
Pull request overview
This PR updates the UploadSaver cURL submission logic to avoid triggering the curl_close() deprecation warning introduced in PHP 8.5 (where curl_close() has been a no-op since PHP 8.0).
Changes:
- Make
curl_close($ch)conditional onPHP_VERSION_ID < 80000to avoid PHP 8.5 deprecation warnings.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
77
to
+85
| $result = curl_exec($ch); | ||
| if ($result === false) { | ||
| $error = curl_errno($ch) ? curl_error($ch) : ''; | ||
| throw new ProfilerException('Failed to submit data' . ($error ? ': ' . $error : '')); | ||
| } | ||
| curl_close($ch); | ||
|
|
||
| if (PHP_VERSION_ID < 80000) { | ||
| curl_close($ch); | ||
| } |
Comment on lines
+83
to
+85
| if (PHP_VERSION_ID < 80000) { | ||
| curl_close($ch); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR updates the
UploadSavercURL submission logic to avoid triggering thecurl_close()deprecation warning introduced in PHP 8.5 (wherecurl_close()has been a no-op since PHP 8.0).Changes:
curl_close($ch)conditional onPHP_VERSION_ID < 80000to avoid PHP 8.5 deprecation warnings.