nightshift/bug: missing HubSpot count in day summary#18
Open
nightshift/bug: missing HubSpot count in day summary#18
Conversation
getDaySummary counted activities from every source (calendar, slack, gmail, docs, trello, github, jira) except hubspot, which was added later. HubSpot deal activities were fetched and displayed correctly but silently omitted from the day summary totals. https://claude.ai/code/session_01EG1HcH5DWijTkARenutW5N
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
getDaySummary()inapp/lib/aggregator.tscounts activities from every source (calendar, slack, gmail, docs, trello, github, jira) excepthubspot. HubSpot deal activities are fetched, aggregated into hourly buckets, and displayed in the timeline, but they are silently omitted from the summary totals returned by the API.Repro
Connect a HubSpot account, view a day with deal activity. The summary object returned by
/api/activitieswill showtotalJiraActivitiesbut nototalHubSpotActivitiesfield -- HubSpot activities are invisible in the summary counts even though they appear in the timeline.Fix
Added
totalHubSpotActivitiescounter togetDaySummary(), filtering communications bysource === "hubspot", matching the pattern used for every other source.