Conversation
Being an etherstub this isn't a sufficient approach to test a guest can reach the actual internet in a VM as one might want in PHD. But it *is* enough to set up virtio-nic devices and do some spot checks that the PCI device works right.
papertigers
reviewed
Apr 20, 2026
Comment on lines
+62
to
+63
| # just build the test binaries here and squirrel them off to *run* on a Gimlet. | ||
| # So do that. |
Contributor
There was a problem hiding this comment.
Suggested change
| # just build the test binaries here and squirrel them off to *run* on a Gimlet. | |
| # So do that. | |
| # just build the test binaries here and squirrel them off to *run* on a Gimlet, | |
| # so do that. |
Contributor
There was a problem hiding this comment.
nit but fine either way
Comment on lines
+12
to
+13
| # That buildomat frontmatter is kinda absurd. We're going to run Propolis | ||
| # tests, but not build them? And `lab-2.0-gimlet` specifically? |
Contributor
There was a problem hiding this comment.
I am not sure if this comment was a note to yourself or if it is supposed to inform future readers.
Member
Author
There was a problem hiding this comment.
I meant this as a lead-in to the comment below it, so definitely for future readers. is there a wording change that would help?
Contributor
There was a problem hiding this comment.
I think just the question marks through me off - we are running the tests and the dependency is the build job.
It's not really a big deal.
papertigers
approved these changes
Apr 20, 2026
Contributor
papertigers
left a comment
papertigers
left a comment
There was a problem hiding this comment.
thanks for putting this together! I think the additional CI time is worth the additional test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
something of a journey but we got there - leaving the commits for humor value but this all gets squashed for the merge of course. and tests pass! yay.