feat(desktop): align inspector rail to spec #3 + Settings shell nav#137
Merged
Conversation
The collapsed inspector rail now matches design spec screen #3 exactly: ‹ expand · ▤ Plan (pending badge) · ◐ Context · 📁 Recent files · ⓘ Session info · ⚙ Settings. The four middle icons are inspector hints — clicking one expands the 320px panel and scrolls to that section (new `focusSection` prop on InspectorPanel + `data-section` anchors). The rail previously doubled as the *only* navigation to Permissions / MCP / Plugins / Skills / About. Per spec screen #9 those live behind the ⚙ cog in a shared Settings shell, so this adds <SettingsLayout> (a `.set-nav` left column + pane) and folds the settings-family screens into it — nothing is stranded. Sessions stay in the left sidebar where the spec puts them. - InspectorRail: trimmed to the 6 spec elements; onExpand(section) / onSettings / settingsActive replace the old screen-routing props. - SettingsLayout + SETTINGS_FAMILY: unified nav for settings-family screens. - App: expandInspector(section), settings-shell wrapping in renderScreen. - index.css: `.settings-shell` / `.set-nav` / `.set-pane` per spec lines 754-768; sticky `.inspector-head` so focused sections land below it. Verified in a browser harness: rail = 48px with exactly ‹/▤(badge)/◐/📁/ⓘ/⚙, panel = 320px, set-nav switches active screen, ⌘\ unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #91 (inspector expand panel). Aligns the collapsed inspector rail to design spec screen #3 and relocates the navigation it used to carry into a spec-faithful Settings shell (screen #9).
The rail now contains exactly the six elements the spec shows:
‹ expand · ▤ Plan (pending badge) · ◐ Context · 📁 Recent files · ⓘ Session info · ⚙ SettingsThe four middle icons are inspector hints — clicking one expands the 320px panel and scrolls to that section (new
focusSectionprop +data-sectionanchors). Only‹/⌘\/icons expand;⚙opens Settings.Why the Settings shell
The old rail doubled as the only entry point to Permissions / MCP / Plugins / Skills / About (the Sidebar only handles sessions). Trimming the rail naively would have stranded those screens. Per spec screen #9 they belong behind the ⚙ cog in a shared
.set-navleft column, so this adds<SettingsLayout>and folds the settings-family screens into it — nothing is unreachable. Sessions stay in the left sidebar where the spec puts them.Changes
onExpand(section)/onSettings/settingsActivereplace the old screen-routing props.SETTINGS_FAMILY— unified left-nav hub for the settings-family screens (General / Permissions / MCP / Plugins / Skills / About). Only real screens are listed (no dead links).focusSectionprop scrolls to the requesteddata-section; sticky header.expandInspector(section), settings-shell wrapping inrenderScreen..settings-shell/.set-nav/.set-paneper spec lines 754–768; sticky.inspector-head.Verification
Browser harness (real components + real
index.css, Tauri IPC bypassed):‹ / ▤(badge) / ◐ / 📁 / ⓘ / spacer / ⚙..set-navswitches the active screen (verified active class + crumb).⌘\toggle unchanged.typecheck,eslint, full monorepo test suite (28 desktop + 618 core, etc.), and production build all pass via pre-commit.🤖 Generated with Claude Code