Skip to content

[GR-71917] Enable test_remove_subclass. #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
graalvmbot wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[GR-71917] Enable test_remove_subclass. #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6959baa
Enable test_remove_subclass
steve-s Apr 14, 2026
2bafac7
Use support.gc_collect in test_descr + heap dump on support.gc_collec…
steve-s Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@ Jsonnet/libsonnet CI definitions consumed by GitHub Actions matrix generation.
## ANTI-PATTERNS
- Don’t encode secrets or environment-specific paths here.
- Keep changes compatible with matrix generation (small diffs, deterministic output).
- NEVER edit CI files in `./graal`
4 changes: 4 additions & 0 deletions ci/python-gate.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,10 @@
python_version: "3.8",
targets: [self.target],
logs+: $.logs(self.os, self.arch),
catch_files+: [
// generated by patch in CPython test support
"HEAP DUMP: (?P<filename>.+\\.hprof)",
],
// all gates share the same base set of downloads
downloads+: $.downloads(self.os, self.arch),
// all gates share the same base environment
Expand Down
3 changes: 1 addition & 2 deletions graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_descr.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ test.test_descr.ClassPropertiesAndMethods.test_python_lists @ darwin-arm64,linux
test.test_descr.ClassPropertiesAndMethods.test_qualname @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_descr.ClassPropertiesAndMethods.test_qualname_dict @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_descr.ClassPropertiesAndMethods.test_recursive_call @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
# GR-71917
!test.test_descr.ClassPropertiesAndMethods.test_remove_subclass
test.test_descr.ClassPropertiesAndMethods.test_remove_subclass @ linux-x86_64
test.test_descr.ClassPropertiesAndMethods.test_repr_as_str @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_descr.ClassPropertiesAndMethods.test_repr_with_module_str_subclass @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_descr.ClassPropertiesAndMethods.test_restored_object_new @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
Expand Down
3 changes: 3 additions & 0 deletions graalpython/lib-python/3/test/support/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,6 +793,9 @@ def gc_collect(until = None):
i += 1
if i > 1000:
print("WARNING: timeout while waiting for GC")
if is_graalpy and hasattr(__graalpython__, 'dump_heap'):
dump_path = __graalpython__.dump_heap()
print(f"HEAP DUMP: {dump_path}")
break

@contextlib.contextmanager
Expand Down
2 changes: 1 addition & 1 deletion graalpython/lib-python/3/test/test_descr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5016,7 +5016,7 @@ class Child(Parent):
self.assertEqual(Parent.__subclasses__(), [Child])

del Child
gc.collect()
support.gc_collect(lambda: len(Parent.__subclasses__()) > 0)
self.assertEqual(Parent.__subclasses__(), [])

def test_attr_raise_through_property(self):
Expand Down
Loading