[FSSDK-12497] Fix return in finally block silently swallowing exceptions#505
Open
FarhanAnjum-opti wants to merge 1 commit intomasterfrom
Open
Conversation
Move error-handling logic out of finally block into normal control flow and change bare except to except Exception. Per Python docs, a return in finally suppresses any in-flight exception, which silently swallows errors raised inside except blocks. Fixes #439 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where a
returnstatement inside afinallyblock in_set_configsilently swallows exceptions. Per Python docs, areturninfinallysuppresses any in-flight exception, meaning errors raised insideexceptblocks are completely lost with no traceback.Changes
finallyinto normal control flow after the try/except blockexcept:toexcept Exception:to avoid catchingKeyboardInterruptandSystemExitexceptblock propagate correctlyJira Ticket
FSSDK-12497
Issues