Fix Coveralls race: upload coverage from one Python version only#62
Merged
Fix Coveralls race: upload coverage from one Python version only#62
Conversation
Previously every matrix job uploaded coverage to Coveralls, which caused the parallel-build race: whichever job finished first closed the build, and the rest failed with "Can't add a job to a build that is already closed". Restrict the upload to the 3.11 job (same pattern as mhcgnomes), eliminating the race.
Coverage Report for CI Build 24740319490Coverage remained the same at 86.471%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restricts the coverage upload step in
.github/workflows/tests.ymlto run only on the 3.11 matrix job (if: matrix.python-version == '3.11').Previously every matrix job (3.9, 3.10, 3.11) uploaded coverage to Coveralls. Whichever finished first closed the build, and the others failed with:
This was a pre-existing flake — lint and tests were passing on all versions. Same pattern as the sibling
mhcgnomesrepo.Test plan