6679: JMC should support project Loom JFR changes#716
Conversation
|
👋 Welcome back aharmaz! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
/template append |
|
@aymane-harmaz The pull request template has been appended to the pull request body |
|
IIRC javaThreadId can be null for native threads that JFR records (GC/VM/JIT threads, etc.). With the new implementation all native threads will be equal to every other native thread. Under the old code, osThreadId distinguished those threads. |
|
Also, isVirtual should be in the IMCMethod interface. |
|
@aymane-harmaz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
This PR :
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/716/head:pull/716$ git checkout pull/716Update a local copy of the PR:
$ git checkout pull/716$ git pull https://git.openjdk.org/jmc.git pull/716/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 716View PR using the GUI difftool:
$ git pr show -t 716Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/716.diff
Using Webrev
Link to Webrev Comment