lua-lsm: return nil for missing wrapped objects#14
Open
chenzongyao200127 wants to merge 2 commits into
Open
Conversation
* lua-lsm: validate inode_init_security xattr output * lua-lsm: own inode_init_security xattr name storage * lua-lsm: document OCFS2 xattr name lifetime issue --------- Signed-off-by: Zongyao Chen <ZongYao.Chen@linux.alibaba.com>
Some Lua accessors expose optional kernel pointers. d_backing_inode(), sk->sk_socket, sock->sk, skb->sk, and skb_to_full_sk() can return NULL, but the accessors wrapped those values as typed userdata. Lua policy then sees a non-nil object and can call methods that dereference the stored pointer without another NULL check. Return nil for missing optional objects, matching the existing convention used by Lua-LSM hook argument marshalling. Signed-off-by: Zongyao Chen <ZongYao.Chen@linux.alibaba.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Lua accessors expose optional kernel pointers. d_backing_inode(), sk->sk_socket, sock->sk, skb->sk, and skb_to_full_sk() can return NULL, but the accessors wrapped those values as typed userdata.
Lua policy then sees a non-nil object and can call methods that dereference the stored pointer without another NULL check.
Return nil for missing optional objects, matching the existing convention used by Lua-LSM hook argument marshalling.
Validation:
Signed-off-by: Zongyao Chen ZongYao.Chen@linux.alibaba.com