Feature/liveview livemonitoring accordion#270
Merged
Conversation
…irmware Updates" for clarity
Contributor
There was a problem hiding this comment.
Pull request overview
This PR streamlines the frontend update and autofocus UIs by refactoring the “System Update” page to focus on firmware-related functionality and by moving “Live Focus Monitoring” controls into the Autofocus “Advanced Parameters” accordion. It also bumps the frontend version to 1.6.3.
Changes:
- Refactor
SystemUpdateControllerUI to remove the in-development system/Docker update sections and keep firmware flashing/wizards. - Move “Live Focus Monitoring” UI into the Autofocus “Advanced Parameters” accordion to reduce default UI clutter.
- Bump frontend version from
1.6.2to1.6.3(package files +src/version.js).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/components/SystemUpdateController.jsx | Removes system/Docker update UI; repositions and cleans up firmware update and wizard UI. |
| frontend/src/components/navigation/SettingsMenu.jsx | Renames Settings menu entry/copy to reflect firmware-focused updates. |
| frontend/src/components/AutofocusController.js | Moves Live Focus Monitoring controls/plot into the Advanced Parameters accordion. |
| frontend/src/version.js | Bumps APP_VERSION to 1.6.3. |
| frontend/package.json | Bumps app version to 1.6.3. |
| frontend/package-lock.json | Bumps lockfile version fields to 1.6.3. |
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
108
to
112
| <Box sx={{ mb: 3 }}> | ||
| <Typography variant="h4" gutterBottom> | ||
| System Updates | ||
| </Typography> | ||
| <Typography variant="body1" color="text.secondary"> | ||
| Manage ImSwitch system updates, Docker images, and device firmware | ||
| Firmware updates | ||
| </Typography> | ||
| </Box> |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
SystemUpdateControllercomponent to focus exclusively on firmware update functionality, removing the in-development system update and Docker management UI. It also moves the "Live Focus Monitoring" controls into the "Advanced Parameters" accordion in theAutofocusControllerfor a cleaner default interface. Minor UI and code cleanup changes are also included.Firmware Update UI Refactor:
SystemUpdateController.jsx, leaving only firmware update and flashing controls. The component is now focused on device firmware management, and the header and descriptions have been updated accordingly. [1] [2] [3]UI/UX Improvements:
AutofocusController.jshave been moved into the "Advanced Parameters" accordion, making the main autofocus UI less cluttered and advanced options accessible but hidden by default. [1] [2]Version Bump:
1.6.2to1.6.3in bothpackage.jsonandpackage-lock.json. [1] [2]