[SDK] Use kAllW3CTraceContext2Flags#4012
[SDK] Use kAllW3CTraceContext2Flags#4012saphal1998 wants to merge 9 commits intoopen-telemetry:mainfrom
kAllW3CTraceContext2Flags#4012Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4012 +/- ##
==========================================
+ Coverage 82.06% 82.06% +0.01%
==========================================
Files 385 385
Lines 15891 15892 +1
==========================================
+ Hits 13039 13040 +1
Misses 2852 2852
🚀 New features to boost your workflow:
|
|
@marcalff I'm a little unsure as to why checks that fail, actually fail, could you perhaps point me to what might have triggered these failures? thank you for the help! |
From the IWYU CI logs: This is only a summary. In this case, see the section Note that the build continues on failures (make -k), to report as many as possible in one run, which is why we have to search for each issue then. |
|
The magic text to look for in logs, in the iwyu_tool section, is: |
|
For the build, please fix include-what-you-use as indicated earlier. For testing, see the existing CI: and add the same for level 2 validation. See also the following directory for tooling: |
| #include <cstdint> | ||
|
|
||
| #include "opentelemetry/nostd/span.h" | ||
| #include "opentelemetry/trace/trace_flags.h" |
There was a problem hiding this comment.
This is the root cause of the new clang-tidy warning, which breaks CI.
This header file includes itself, remove.
Fixes #2283
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes