test: use heapdump test for SecureContext memory tracking#62689
Open
mertcanaltin wants to merge 2 commits intonodejs:mainfrom
Open
test: use heapdump test for SecureContext memory tracking#62689mertcanaltin wants to merge 2 commits intonodejs:mainfrom
mertcanaltin wants to merge 2 commits intonodejs:mainfrom
Conversation
mertcanaltin
force-pushed
the
fix/remove-cctest-memory-tracking
branch
from
fc600de to
8b10dc3
Compare
nodejs-github-bot
added
needs-ci
mertcanaltin
force-pushed
the
fix/remove-cctest-memory-tracking
branch
from
8b10dc3 to
2f7595c
Compare
mertcanaltin
force-pushed
the
fix/remove-cctest-memory-tracking
branch
from
2f7595c to
9fcc36d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62689 +/- ##
========================================
Coverage 89.81% 89.81%
========================================
Files 699 699
Lines 216331 216465 +134
Branches 41355 41381 +26
========================================
+ Hits 194294 194421 +127
+ Misses 14156 14140 -16
- Partials 7881 7904 +23 🚀 New features to boost your workflow:
|
joyeecheung
reviewed
Apr 13, 2026
mertcanaltin
force-pushed
the
fix/remove-cctest-memory-tracking
branch
from
6474bef to
a0b2175
Compare
joyeecheung
approved these changes
Apr 14, 2026
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace cctest with a heap snapshot test for SecureContext memory tracking.
Refs: #59051
@joyeecheung #59051 (comment)