Skip to content

Megaport fixes#378

Open
i3dnet-akoopen wants to merge 5 commits intonetworktocode:developfrom
i3dnet-akoopen:patch-1
Open

Megaport fixes#378
i3dnet-akoopen wants to merge 5 commits intonetworktocode:developfrom
i3dnet-akoopen:patch-1

Conversation

@i3dnet-akoopen
Copy link
Copy Markdown

Megaport fixes:

  • Megaport sends initial maintenance announcements and reminder announcements. This parser was failing for the initial maintenance announcement which starts with "Please be advised that" instead of "This is a reminder". This fix should account for both emails.
  • For their intial maintenance announcement the start and end date are not in separate paragraphs (in the reminder email this is the case). This fix should account for both emails.
  • The "purpose of maintenance:"-section is used for the summary field of the maintenance. It seems that in newer emails the contents is being put in a separate paragraph. Account for both scenarios with this fix.

Lastly, I will also reach out to Megaport and ask if they can implement the BCOP standard as that seems more sensible then having to make these fixes :)

Megaport fixes for initial maintenance announcement emails
@jvanderaa
Copy link
Copy Markdown
Contributor

@i3dnet-akoopen can you take a look at the tests that are failing?

@i3dnet-akoopen
Copy link
Copy Markdown
Author

@jvanderaa hmm! could you give me some pointers on how I can resolve these tests failing?

@itdependsnetworks
Copy link
Copy Markdown
Contributor

You can run the tests locally, but they show up here: https://github.com/networktocode/circuit-maintenance-parser/actions/runs/22308122203/job/64560316105.

So far there is:

  1. pylint failing
  2. need to add a changelog (see changes folder for example)
  3. the parser is not matching expected results (i think an extra space)

Reduce amount of local variables to make pylint happy
Remove trailing space in summary-field
Add change text for PR 378
@i3dnet-akoopen
Copy link
Copy Markdown
Author

@itdependsnetworks thanks for you input, this the first time for me sending a PR for this project. I think I should fixed those issues now, could you trigger a test-run again?

Comment thread circuit_maintenance_parser/parsers/megaport.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants