Add Obtainium badge for Android APK installation#737
Open
philippgille wants to merge 1 commit intonetbirdio:mainfrom
Open
Add Obtainium badge for Android APK installation#737philippgille wants to merge 1 commit intonetbirdio:mainfrom
philippgille wants to merge 1 commit intonetbirdio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For people who like installing apps via released APK files instead of the Play Store there's an app called Obtainium where you add a GitHub repo as source, and it watches the releases for updates.
This PR adds a badge image (this one) to the docs repo, and embeds that image in the Android install docs, with a link to an Obtainium URL which opens the app and a view where the NetBird repo is configured.
Unfortunately the way the image is embedded, when just clicking on it it leads to a preview of the image, instead of opening the Obtainium URL, and you have to right-click and open the link in a new tab to actually be redirected. But it's the same behavior with the Google Play badge above. Maybe a different
classNameshould be used for both? But that could be a separate PR, while this one focuses on just adding the Obtainium badge with the same behavior as the Google Play badge.Tested with
npm install && npm run devon my laptop, then visiting the network IP on my Android phone, where Obtainium is installed.