setup-key auth instrumentation test#178
Draft
pappz wants to merge 5 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pappz
force-pushed
the
ci/instrumentation-setup
branch
3 times, most recently
from
b0e92ca to
c27d5c4
Compare
pappz
had a problem deploying
to
instrumentation-test-secrets
GitHub Actions
Failure
pappz
force-pushed
the
ci/instrumentation-setup
branch
from
c27d5c4 to
693794e
Compare
pappz
changed the title
pappz
had a problem deploying
to
instrumentation-test-secrets
GitHub Actions
Failure
pappz
force-pushed
the
ci/instrumentation-setup
branch
from
693794e to
51de4b7
Compare
pappz
had a problem deploying
to
instrumentation-test-secrets
GitHub Actions
Failure
Adds SetupKeyAuthTest, a UiAutomator-driven instrumentation test that drives the in-app "Change server" screen end-to-end with a setup key and waits for the success dialog. The test taps "Use NetBird", so the management URL is the one hard-coded in the app (Preferences.defaultServer()). The setup key comes from an instrumentation runner argument so CI can inject it as a secret without baking it into the APK. Wires it into the existing build-debug workflow as a workflow_dispatch-only job that reuses the netbird-aar artifact, so PR builds are unaffected and the AAR is built only once per run. Required repo config: - Secret: INSTRUMENTATION_NB_SETUP_KEY (UUID, ideally reusable + ephemeral)
pappz
force-pushed
the
ci/instrumentation-setup
branch
from
51de4b7 to
ff01cea
Compare
pappz
had a problem deploying
to
instrumentation-test-secrets
GitHub Actions
Failure
pappz
had a problem deploying
to
instrumentation-test-secrets
GitHub Actions
Failure
Run adb screenrecord in a background loop (180s segments) for the full duration of connectedDebugAndroidTest, then upload the segments as an artifact. Helps diagnose UiAutomator failures that only repro in CI.
pappz
had a problem deploying
to
instrumentation-test-secrets
GitHub Actions
Failure
- setup-go: point cache-dependency-path to netbird/go.sum so the Go module cache actually restores (build-android-lib.sh shaves ~1-2 min). - Cache the NDK install dir and the gomobile binary by pinned version, skipping the corresponding install step on cache hit. - Cache the AVD plus the API 30 google_apis x86_64 system image, add a warm-up step that boots once to capture a snapshot, and run tests with force-avd-creation=false plus -no-snapshot-save so subsequent jobs load the cached snapshot without overwriting it. - Move the screenrecord/gradle/pull pipeline to .github/scripts/run-instrumented-tests.sh because the emulator-runner action executes each line of the inline script as a separate sh -c, which broke the multi-line subshell loop.
pappz
had a problem deploying
to
instrumentation-test-secrets
GitHub Actions
Failure
The ${{ env.ANDROID_HOME }} expression resolves against workflow-level
env, not the runner's process environment, so the NDK and AVD system-
image cache paths came out empty-prefixed and the saves were dropped
with "Path Validation Error". Hardcode the ubuntu-latest sdk path
(/usr/local/lib/android/sdk) for both.
Also fix the screen recording: touch the sentinel file BEFORE launching
the background loop, otherwise the loop sees no file on its first
iteration and exits immediately, producing zero recordings.
pappz
had a problem deploying
to
instrumentation-test-secrets
GitHub Actions
Failure
Save threadtime-format logcat to screen-recordings/logcat.log in the background, in parallel with the screenrecord loop, and stop it after the test exits. The existing screen-recordings/ artifact upload picks it up automatically.
pappz
had a problem deploying
to
instrumentation-test-secrets
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetupKeyAuthTest— a UiAutomator-driven instrumentation test that drives the in-app "Change server" screen end-to-end with a setup key, then waits for the success dialog.instrumentation-tests.yml(workflow_dispatch only) that builds the debug AAR via the existingbuild-androidcomposite action, then runs the test on an x86_64 emulator withreactivecircus/android-emulator-runner.Required repository config
INSTRUMENTATION_NB_SETUP_KEY(UUID setup key, ideally reusable + ephemeral)INSTRUMENTATION_NB_MANAGEMENT_URL(defaults tohttps://api.netbird.io)Test plan
ci/instrumentation-setup.setup-key-auth-test-resultsartifact for the JUnit/HTML reports.Draft because we want to validate the workflow on this branch before merging into
main.