fix: avoid scientific notation in CMR URL coordinate parameters#112
Closed
stark256-spec wants to merge 2 commits into
Closed
fix: avoid scientific notation in CMR URL coordinate parameters#112stark256-spec wants to merge 2 commits into
stark256-spec wants to merge 2 commits into
Conversation
- Add Query.client_id() convenience method that sets the Client-Id header. When called without arguments it defaults to python_cmr-<version>; when called with a name it produces <name>/python_cmr-<version>. Closes nasa#49. - Update GranuleCollectionBaseQuery.platform() to accept either a single string or a list of strings, matching CMR's support for multi-platform filtering. Closes nasa#80.
Python's default float formatting uses scientific notation for numbers outside roughly [1e-4, 1e16) — e.g. 0.00001 becomes 1e-05. CMR rejects scientific notation in URL parameters with "is not a valid URL encoded point", causing otherwise valid queries to fail silently. Add _format_float() which falls back to fixed-point formatting whenever the default %g representation contains 'e' or 'E'. Apply it in all five coordinate methods: point(), circle(), polygon(), bounding_box(), line(). Fixes nasa#108
17c4fa3 to
92b9b4e
Compare
Collaborator
|
Thanks @stark256-spec. The default branch is |
Author
|
Done — retargeted to |
Author
|
Closing this in favour of a clean replacement — the branch inadvertently included unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #108
Python's default float-to-string conversion uses scientific notation for numbers outside roughly
[1e-4, 1e16). For example,0.00001becomes"1e-05". CMR rejects scientific notation in URL parameters:This caused queries using coordinates near the equator (or any latitude/longitude/distance with small absolute value) to fail.
Fix
Added
_format_float()which checks whether the defaultg-format string containse/Eand falls back to fixed-point formatting with trailing zeros stripped:Applied to all five coordinate methods:
point(),circle(),polygon(),bounding_box(),line().Test