Skip to content

[DISCO-4151] Merino: add client for wcs#7345

Open
tiftran wants to merge 6 commits intomainfrom
wcs
Open

[DISCO-4151] Merino: add client for wcs#7345
tiftran wants to merge 6 commits intomainfrom
wcs

Conversation

@tiftran
Copy link
Copy Markdown
Contributor

@tiftran tiftran commented Apr 30, 2026

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@tiftran tiftran force-pushed the wcs branch 2 times, most recently from 0c1055a to ccb9dcc Compare April 30, 2026 17:46
Comment thread components/merino/src/worldcup/http.rs Outdated
Comment thread examples/merino-cli/src/main.rs Outdated
/// Fetch World Cup data
WorldCup {
/// OHTTP relay URL
#[arg(long, default_value = "https://ohttp-merino.mozilla.fastly-edge.com")]
Copy link
Copy Markdown

@annasob annasob May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nan said no need for OHTTP since no search data is being passed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

@tiftran tiftran marked this pull request as ready for review May 1, 2026 19:03
@tiftran tiftran requested review from a team and annasob May 1, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants