Skip to content

refactor(profile): migrate edit profile modal to SolidJS (@AzureNightlock)#7900

Open
AzureNightlock wants to merge 1 commit intomonkeytypegame:masterfrom
AzureNightlock:refactor/edit-profile-modal
Open

refactor(profile): migrate edit profile modal to SolidJS (@AzureNightlock)#7900
AzureNightlock wants to merge 1 commit intomonkeytypegame:masterfrom
AzureNightlock:refactor/edit-profile-modal

Conversation

@AzureNightlock
Copy link
Copy Markdown
Contributor

@AzureNightlock AzureNightlock commented May 3, 2026

Description

This PR: Migrates the Edit Profile modal to a SolidJS component

Changes Made:

  • Added the new SolidJS + Tanstack EditProfile popup component
  • Sends the updated profile details to the backend when the form is saved
  • Immediately updates the page to show the new updated values
  • Integrated the new EditProfile popup into UserDetails
  • Deleted the edit-profile.ts and the popup dialog from popups.html
  • Removed the event-handler from account.ts
  • Removed popups.scss for edit-profile

Additional Changes Made:

  • Changed twitter schema maxlength to 15 instead of 20
  • Using tailwind instead of popups.scss
  • Added EditProfile to modals.ts

Checks

  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #7683

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label May 3, 2026
@AzureNightlock AzureNightlock changed the title Refactor/edit profile modal refactor(profile): migrate edit profile modal to SolidJS (@AzureNightlock) May 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions Bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for update Pull requests or issues that require changes/comments before continuing labels May 3, 2026

<div>
<label class="text-sub mb-[0.25em] block">bio</label>
<form.Field name="bio">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's extract the schema for bio and keyboard from UserProfileDetailsSchema and use it here for validation

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions Bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for update Pull requests or issues that require changes/comments before continuing labels May 3, 2026
@AzureNightlock
Copy link
Copy Markdown
Contributor Author

AzureNightlock commented May 3, 2026

Sorry for the inconvience, I have added maxLength to TextareaField and changed validations accordingly

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions Bot added the waiting for update Pull requests or issues that require changes/comments before continuing label May 3, 2026
@AzureNightlock AzureNightlock force-pushed the refactor/edit-profile-modal branch from 0ebe1a9 to c623967 Compare May 3, 2026 12:02
@github-actions github-actions Bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label May 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions Bot added the waiting for update Pull requests or issues that require changes/comments before continuing label May 3, 2026
@AzureNightlock AzureNightlock requested a review from fehmer May 3, 2026 12:16
@github-actions github-actions Bot added waiting for review Pull requests that require a review before continuing and removed waiting for update Pull requests or issues that require changes/comments before continuing labels May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff waiting for review Pull requests that require a review before continuing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Profile saves even when no changes are made

3 participants