fix(product): автоматический class_key msProduct в Product\Create (#305)#306
Open
Ibochkarev wants to merge 1 commit into
Open
fix(product): автоматический class_key msProduct в Product\Create (#305)#306Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
…305) MODX Resource\Create defaults missing class_key to modDocument; ensure the product create processor applies $this->classKey before parent initialize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
При создании товара через процессор
MiniShop3\Processors\Product\Create, если в запросе не переданclass_key(или пришёл дефолт MODXmodDocument), ресурс создавался как обычный документ вместоmsProduct.В
initialize()перед вызовом родительскогоResource\Createподставляется$this->classKey, когдаclass_keyотсутствует, пустой или равенmodDocument. Явно переданныйclass_key(например, из Vue-менеджера) не перезаписывается.Тип изменений
Связанные Issues
Closes #305
Как это было протестировано?
class_keyв query — ресурс должен бытьMiniShop3\Model\msProduct)php -lдля изменённого файлаКонфигурация тестирования:
Скриншоты (если применимо)
class_key→modDocumentclass_key→msProductЧеклист
Дополнительные заметки
Корневая причина:
MODX\Revolution\Processors\Resource\Create::initialize()читаетclass_keyиз свойств запроса с дефолтомmodDocument, игнорируя$classKeyпроцессора. Свойствоpublic $classKey = msProduct::classвProduct\Createсамо по себе не срабатывало.