test: ssr remote leak#4664
Conversation
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/data-prefetch
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
2heal1
force-pushed
the
test/ssr-remote-leak
branch
from
fefe775 to
fe5bc76
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fefe77556b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| expect(manifestLoading2).toEqual([manifestV1, manifestV2]); | ||
| expect(remoteSnapshotKeys2).toEqual([ |
There was a problem hiding this comment.
These assertions lock in the known buggy state by expecting both old and new manifest/snapshot keys after registerRemotes(..., { force: true }). That means when runtime cleanup is implemented, CI will fail and effectively block the fix until this test is rewritten. The test should assert the intended post-fix state (only the latest manifest/snapshot key remains) so it protects against regressions instead of preserving the leak.
Useful? React with 👍 / 👎.
Bundle Size Report11 package(s) changed, 29 unchanged. Package dist + ESM entry
Bundle targets
Consumer scenarios
Total dist (raw): 6.31 MB (+8 B (+0.0%)) Bundle sizes are generated with rslib (Rspack). Package-root metrics preserve the historical report. Tracked subpath exports such as |
Add a Node/SSR vitest spec that demonstrates global manifest/snapshot caches
are retained when calling registerRemotes(..., { force: true }) for the same
remote name with a different manifest entry. Also include an unloadRemote API
proposal doc for a future fix.
2heal1
force-pushed
the
test/ssr-remote-leak
branch
from
fe5bc76 to
8ac9978
Compare
1 participant
Description
Related Issue
Types of changes
Checklist