Improve diagnostics.source.#14500
Open
sean-mcmanus wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Refines the diagnostic.source strings used for diagnostics emitted by the C/C++ extension so consumers (e.g. Copilot) can distinguish IntelliSense, clang-tidy, and refactor diagnostics from generic "C/C++" compiler diagnostics. Introduces a new CppIntelliSenseSourceStr constant and updates the missing-include detection to match the new source value.
Changes:
- Add
CppIntelliSenseSourceStr("C/C++ IntelliSense") and updateisMissingIncludeDiagnosticto compare against it. - Tag clang-tidy and refactor diagnostics with more specific source strings ("C/C++ clang-tidy", "C/C++ Refactor").
- Set IntelliSense diagnostics' source to
CppIntelliSenseSourceStrinDefaultClient.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Extension/src/LanguageServer/extension.ts | Adds the CppIntelliSenseSourceStr constant and updates the missing-include diagnostic check to use it. |
| Extension/src/LanguageServer/codeAnalysis.ts | Tags clang-tidy diagnostics with the more specific "C/C++ clang-tidy" source. |
| Extension/src/LanguageServer/client.ts | Imports the new constant, tags refactor diagnostics with "C/C++ Refactor", and sets IntelliSense diagnostics' source to CppIntelliSenseSourceStr. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Colengms
approved these changes
Jun 1, 2026
Contributor
Author
|
I want to make sure @bobbrow is okay with this before checking it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is primarily for if/when microsoft/vscode#319418 gets fixed so Copilot can more easily know it's a not an actual C/C++ compiler error.
...but I figured it might help new users as well.