fix(server): clearCookies({name}) should not transiently delete other cookies#40955
Open
adityasingh2400 wants to merge 4 commits into
Open
fix(server): clearCookies({name}) should not transiently delete other cookies#40955adityasingh2400 wants to merge 4 commits into
adityasingh2400 wants to merge 4 commits into
Conversation
… cookies BrowserContext.clearCookies(options) currently wipes every cookie via doClearCookies() and then re-adds the ones that did not match the filter. Pages that subscribe to cookieStore.change observe a transient deletion of the kept cookies during the gap between the wipe and the readd, which is enough to trip route-guards, useSyncExternalStore-style auth state machines, and similar. When a filter (name, domain, or path) is set, expire only the matching cookies in place by calling addCookies with expires=0; the no-filter path still delegates to doClearCookies() as before. No per-browser code is changed. Reported and diagnosed by @jasikpark in microsoft#40953.
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Test results for "MCP"7181 passed, 1113 skipped Merge workflow run. |
Contributor
Test results for "tests 1"3 flaky42071 passed, 854 skipped Merge workflow run. |
Contributor
Author
|
@microsoft-github-policy-service agree |
…ned cookies Adds coverage for two cases the new filtered-clearCookies path in microsoft#40955 does not handle: __Secure- prefixed cookies (rejected by Chromium because the expire payload omits secure:true) and partitioned (CHIPS) cookies (silently survive because partitionKey is dropped from the expire payload).
Same root cause as the __Secure- regression: without secure/sameSite in the expire payload, Chromium rejects the cookie with "Invalid cookie fields".
…arCookies Spread the original cookie into the expire payload instead of picking name/domain/path. Without secure/sameSite/partitionKey/_crHasCrossSiteAncestor, Chromium rejects __Secure- and __Host- prefixed cookies with "Invalid cookie fields" and silently leaves partitioned (CHIPS) cookies in place.
Member
|
Code looked good, I found some regressions that I covered with tests + fixed. @yury-s could you take a look since you last touched Cookie around CHIPS? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40953.
BrowserContext.clearCookies(options)currently wipes every cookie viadoClearCookies()and then re-adds the ones that did not match the filter. Pages that subscribe to thecookieStore.changeAPI observe a transient deletion of the kept cookies during the gap between the wipe and the readd, which is enough to trip route-guards,useSyncExternalStore-style auth state machines, and similar listeners. WithcookieStorenow Baseline 2025, this race window is observable from user code.When a filter (
name,domain, orpath) is set, this PR expires only the matching cookies in place by callingaddCookieswithexpires: 0; the no-filter path still delegates todoClearCookies()as before, so no per-browser code is touched.Credit to @jasikpark for the full root-cause analysis and the proposed fix shape in the issue.
Added a Chromium-only test in
tests/library/browsercontext-clearcookies.spec.tsthat adds two cookies, subscribes tocookieStore.changevia the page, then callsclearCookies({ name: 'delete_me' })and asserts the kept cookie never appears in a deletion event.