Speed up tests targeting invalid servers#1622
Draft
David-Engel wants to merge 2 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1622 +/- ##
=======================================
Coverage 85.72% 85.72%
=======================================
Files 23 23
Lines 7210 7210
=======================================
Hits 6181 6181
Misses 1029 1029 🚀 New features to boost your workflow:
|
This was referenced May 13, 2026
This was referenced May 16, 2026
This was referenced May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Low hanging fruit to save a little time on test runs.
This pull request updates several functional tests for both
pdo_sqlsrvandsqlsrvdrivers to ensure that connection attempts to invalid servers fail quickly. The main change is the addition of aLoginTimeout = 1parameter to connection strings and options, which reduces the time spent waiting for a connection to fail when testing error handling. This will make the test suite run faster and more reliably when simulating failed connections.Test reliability and speed improvements:
LoginTimeout = 1to DSNs and connection options in multiplepdo_sqlsrvtest files to ensure invalid server connection attempts fail quickly. [1] [2] [3] [4]sqlsrv_connectcalls in severalsqlsrvtest files to include'LoginTimeout' => 1in the connection options for invalid server scenarios. [1] [2] [3] [4] [5]