Prevent reading uninitialized memory in unix_detect_thp()#1297
Open
svart-riddare wants to merge 1 commit into
Open
Prevent reading uninitialized memory in unix_detect_thp()#1297svart-riddare wants to merge 1 commit into
svart-riddare wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buf[32]contains uninitialized memory; once reading the file content we search for a particular string which, if not found in the file read, leads to comparing uninitialized bytes at the end ofbufto the string we are looking for, leading to undefined behavior (altough it would be highly unlikely that the uninitialized bytes would contain the string we are looking for).