fix: Add layout refresher callback to ChatInputTextViewer for dynamic height adjustments#219
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #215 where recalling long chat input history could cause the chat input to grow without the containing chat view relayouting, hiding the bottom picker/action row. It does so by replacing a brittle fixed parent traversal in ChatInputTextViewer with an owner-provided relayout callback, and adds SWTBot coverage to validate picker visibility after history recall.
Changes:
- Add a
layoutRefreshercallback hook toChatInputTextViewerand invoke it after height-hint updates. - Wire the relayout callback from
ActionBarto request a relayout of the chat view container when the input height changes, and tag the mode picker with a SWTBot widget id. - Update SWTBot probe execution to support arrow key posting and add a new probe script reproducing the history-recall layout scenario.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/ChatInputTextViewer.java | Introduces a relayout callback to avoid fixed-depth parent layout calls when input height changes. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/ActionBar.java | Wires the new relayout callback and adds a SWTBot widget id for the mode picker. |
| com.microsoft.copilot.eclipse.swtbot.test/src/com/microsoft/copilot/eclipse/swtbot/test/probe/StepExecutor.java | Enhances probe key handling by posting SWT key events and adds direct StyledText focus/text support. |
| com.microsoft.copilot.eclipse.swtbot.test/probe-scripts/chat-input-history-layout-001.json | Adds an SWTBot probe to validate pickers remain visible after recalling a long input from history. |
xinyi-gong
reviewed
May 18, 2026
… input height adjustments
d7ae58d to
9378d97
Compare
jdneo
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


fix #215