Open
Conversation
Detects usage of SSL 3.0, TLS 1.0, and TLS 1.1 via SecurityProtocolType and SslProtocols enum references. Covers: Cryptography.10031 (CWE-327, CWE-757) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the unsafe deserializers available in csharp but now in powershell!
Weird thing about this PR is how it splits up the different kinds of .NET APIs are invoked in powershell:
InstanceDeserializerSink — Creates an object, then calls a method on it:
$fmt = New-Object System.Runtime.Serialization.Formatters.Soap.SoapFormatter
$fmt.Deserialize($stream) # ← sink is $stream
Requires tracking that $fmt was created as an unsafe type, then matching the method call on it.
StaticDeserializerSink — Call a static method directly on the type (no object creation):
[System.Windows.Markup.XamlReader]::Parse($xaml) # ← sink is $xaml
No New-Object involved — just [Type]::Method(). Needs different matching logic (check isStatic() + the type qualifier).
UnsafeConstructorSink — The constructor itself is the dangerous operation (not a follow-up method):
$r = New-Object System.Resources.ResourceReader -ArgumentList $pat
ResourceReader deserializes the resource file at construction time, so the constructor argument is the sink
Each of the deserializers is classified into of the above, except BinaryFormatter which is separate since it's still used by the BinaryFormatter query