Potentially uninitialized variables in bindview#1373
Merged
5an7y-Microsoft merged 1 commit intoMay 7, 2026
Merged
Conversation
These changes eliminate the warnings below in bindview.cpp by initializinf the variables mentioned. 1449 The status of this call to externally defined (SAL) GetCursorPos is not checked, potentially leaving pt uninitialized. 1528 The status of this call to externally defined (SAL) GetCursorPos is not checked, potentially leaving pt uninitialized. 1825 The status of this call to externally defined (SAL) GetDeviceStatus is not checked, potentially leaving ulStatus uninitialized.
alex-bozhko
approved these changes
Apr 24, 2026
Author
|
@5an7y-Microsoft , could you please merge this PR? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the Windows Driver Developer Supplemental Tools on bindview with "recommended" and "must-fix" codeql queries results in these warnings in
bindview.cpp:These changes eliminate these warnings by initializing the variables mentioned.