Enhance comment handling support#209
Merged
Merged
Conversation
rwestMSFT
requested review from
chlafreniere,
dzsquared,
kburtram,
llali and
ssreerama
as code owners
llali
requested changes
Jun 4, 2026
Member
llali
left a comment
llali
left a comment
There was a problem hiding this comment.
the PR addresses more than one issue and it makes it too big and hard to review. I'm ok to approve this since the code won't affect the default behavior of parsers but please make smaller changes in each PR in upcoming PRs.
llali
requested changes
Jun 4, 2026
Contributor
Author
I did try and break it up, but it would have created unexpected behaviour. Thanks for the feedback. |
llali
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces significant improvements to how comments are preserved and emitted in the SQL Server script generator, especially around statement boundaries and formatting. The main focus is on ensuring that comments maintain their correct placement relative to SQL statements, particularly for trailing comments, single-line comments, and comments between statements and keywords like
END. These changes improve the fidelity of script round-tripping and formatting.Code Changes