Skip to content

fix(library): handle circular schema references#2854

Merged
baywet merged 2 commits into
mainfrom
security/ref-loop
May 26, 2026
Merged

fix(library): handle circular schema references#2854
baywet merged 2 commits into
mainfrom
security/ref-loop

Conversation

@baywet
Copy link
Copy Markdown
Member

@baywet baywet commented May 26, 2026

Summary

  • Handle circular schema references without failing document loading.
  • Add regression coverage for circular schema references.

Testing

  • dotnet test .\test\Microsoft.OpenApi.Readers.Tests\Microsoft.OpenApi.Readers.Tests.csproj --no-restore --no-logo
  • dotnet test .\test\Microsoft.OpenApi.Tests\Microsoft.OpenApi.Tests.csproj --no-restore --no-logo

@baywet baywet requested a review from a team as a code owner May 26, 2026 11:12
@baywet baywet force-pushed the security/ref-loop branch from 5e16d99 to ae7c5d9 Compare May 26, 2026 12:04
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
adrian05-ms
adrian05-ms previously approved these changes May 26, 2026
@baywet
Copy link
Copy Markdown
Member Author

baywet commented May 26, 2026

@copilot refresh the benchmark reports, change nothing else

Copy link
Copy Markdown
Contributor

Copilot AI commented May 26, 2026

@copilot refresh the benchmark reports, change nothing else

Done in 18637f9 — benchmark reports have been refreshed, and no other files were changed.

Copilot finished work on behalf of baywet May 26, 2026 15:05
@baywet baywet enabled auto-merge May 26, 2026 15:09
@baywet baywet self-assigned this May 26, 2026
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
6.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@baywet baywet merged commit b3cd42b into main May 26, 2026
15 of 18 checks passed
@baywet baywet deleted the security/ref-loop branch May 26, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants