Skip to content

Bug 635880: Re-enable PEPPOL DE service invoice/cr.memo tests#8262

Open
Groenbech96 wants to merge 1 commit into
mainfrom
bug/635880-reenable-peppol-de-service-tests
Open

Bug 635880: Re-enable PEPPOL DE service invoice/cr.memo tests#8262
Groenbech96 wants to merge 1 commit into
mainfrom
bug/635880-reenable-peppol-de-service-tests

Conversation

@Groenbech96
Copy link
Copy Markdown
Contributor

@Groenbech96 Groenbech96 commented May 21, 2026

What & why

The root cause of AB#635880 (Sell-to E-Mail not propagated during PEPPOL DE validation of posted service documents) has been fixed in the DE localization layer. This PR removes the PEPPOLDEServiceTests.json disabled-tests file introduced as a temporary workaround in PR #8113.

Tests re-enabled

PEPPOL30 Management Tests (139235):

  • PEPPOL_XMLExport_DeliveryInfo_ServiceInvoice
  • PEPPOL_XMLExport_DeliveryInfo_ServiceCrMemo

PEPPOL BIS BillingTests (139236):

  • ExportXml_PEPPOL_BIS3_ServiceInvoice
  • ExportXml_PEPPOL_BIS3_ServiceCrMemo
  • ExportXml_PEPPOL_BIS3_ServiceInvoiceFCY
  • ExportXml_PEPPOL_BIS3_ServiceCrMemoFCY
  • ExportXml_ServiceInvoiceLCY_InvRounding_Positive

Linked work

Fixes AB#635880
Related: PR #8113 (introduced the workaround)

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • No new tests added — this PR only removes the disabled-test entries; the tests themselves already exist and are now re-enabled.

🤖 Generated with Claude Code

The root cause (Sell-to E-Mail not propagated during PEPPOL DE
validation of posted service documents) has been fixed in the DE
localization layer. Remove the DisabledTests file that was introduced
as a temporary workaround in PR #8113.

Re-enables in PEPPOL30 Management Tests (139235):
- PEPPOL_XMLExport_DeliveryInfo_ServiceInvoice
- PEPPOL_XMLExport_DeliveryInfo_ServiceCrMemo

Re-enables in PEPPOL BIS BillingTests (139236):
- ExportXml_PEPPOL_BIS3_ServiceInvoice
- ExportXml_PEPPOL_BIS3_ServiceCrMemo
- ExportXml_PEPPOL_BIS3_ServiceInvoiceFCY
- ExportXml_PEPPOL_BIS3_ServiceCrMemoFCY
- ExportXml_ServiceInvoiceLCY_InvRounding_Positive

Fixes AB#635880

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@Groenbech96 Groenbech96 requested a review from a team as a code owner May 21, 2026 08:29
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label May 21, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant