Skip to content

Allow mix of int and bigint#8258

Merged
BardurKnudsen merged 1 commit into
mainfrom
features/578380-BigInt
May 21, 2026
Merged

Allow mix of int and bigint#8258
BardurKnudsen merged 1 commit into
mainfrom
features/578380-BigInt

Conversation

@BardurKnudsen
Copy link
Copy Markdown
Contributor

@BardurKnudsen BardurKnudsen commented May 21, 2026

As we are introducing BigInteger entry nos. in BaseApp, we need to be able to compile extensions in 'mixed-mode' where we blend integer and biginteger. Currently BCApps apps block the uptake in baseapp (and vice versa).

Fixes AB#578380

@BardurKnudsen BardurKnudsen requested a review from a team as a code owner May 21, 2026 07:53
@BardurKnudsen BardurKnudsen enabled auto-merge (squash) May 21, 2026 08:00
@github-actions github-actions Bot added this to the Version 29.0 milestone May 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

$\textbf{🟠\ High\ Severity\ —\ Upgrade} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

AS0023 breaking-change rule downgraded to Warning

AS0023 prevents adding table fields with a lower ordinal than existing fields, which is a breaking change for all dependent extensions. Downgrading it to Warning means such violations will silently pass CI builds instead of failing them.

Recommendation:

  • Keep AS0023 at "action": "Error" (or remove the override entirely) to preserve breaking-change protection. If BigInteger entry numbers genuinely require lower ordinals, document the migration path and coordinate with all dependent extensions before relaxing this rule.
    {
        "id": "AS0023",
        "action": "Error",
        "justification": "Needed to allow for BigInteger entry nos."
    },

Line mapping was unavailable, so this was posted as an issue comment.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why

Comment thread src/rulesets/ruleset.json
@JesperSchulz JesperSchulz changed the title Allow mix if int and bigint Allow mix of int and bigint May 21, 2026
@BardurKnudsen BardurKnudsen merged commit fc30ff7 into main May 21, 2026
92 of 95 checks passed
@BardurKnudsen BardurKnudsen deleted the features/578380-BigInt branch May 21, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants